[SYCL][COMPAT] Add vectorized_ternary and vectorized_with_pred. #15550

tangjj11 · 2024-09-30T08:29:12Z

Add vectorized_ternary and vectorized_with_pred.
Update relu and vectorized_binary.

Signed-off-by: Tang, Jiajun [email protected]

Alcpz

Thanks for the contribution to the headers and for extending the testing helpers. I've left a few comments.

sycl/include/syclcompat/math.hpp

sycl/test-e2e/syclcompat/math/math_vectorized.cpp

Add vectorized_ternary and vectorized_with_pred. Update relu and vectorized_binary. Signed-off-by: Tang, Jiajun [email protected]

joeatodd

LGTM, thanks for taking our suggestions on board 👍

Alcpz · 2024-10-23T10:55:02Z

@tangjj11 Thanks for the contribution 👍
@intel/llvm-gatekeepers this is ready for merging

tangjj11 requested a review from a team as a code owner September 30, 2024 08:29

tangjj11 temporarily deployed to WindowsCILock September 30, 2024 08:29 — with GitHub Actions Inactive

tangjj11 had a problem deploying to WindowsCILock September 30, 2024 08:54 — with GitHub Actions Failure

Alcpz added the syclcompat Issues related to SYCLcompat label Oct 1, 2024

Alcpz suggested changes Oct 1, 2024

View reviewed changes

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 02:05 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 08e03a5 to 2944ced Compare October 8, 2024 05:40

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 05:41 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 2944ced to 0ced2b2 Compare October 8, 2024 06:34

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 06:35 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 0ced2b2 to a3d3deb Compare October 8, 2024 07:14

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 07:15 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from a3d3deb to 4f56861 Compare October 8, 2024 08:13

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 08:14 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 4f56861 to 94a2ecd Compare October 8, 2024 08:49

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 08:50 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 94a2ecd to 5dcf0aa Compare October 8, 2024 10:15

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 10:16 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 5dcf0aa to 41f8174 Compare October 8, 2024 10:57

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 10:58 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 41f8174 to f276658 Compare October 8, 2024 11:44

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 11:46 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from f276658 to 9884622 Compare October 8, 2024 12:27

tangjj11 had a problem deploying to WindowsCILock October 8, 2024 12:29 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 9884622 to 23211ef Compare October 9, 2024 01:19

tangjj11 had a problem deploying to WindowsCILock October 9, 2024 01:20 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 23211ef to 42bde45 Compare October 9, 2024 03:25

tangjj11 had a problem deploying to WindowsCILock October 9, 2024 03:26 — with GitHub Actions Error

tangjj11 force-pushed the simd branch from 42bde45 to 0f9bfcd Compare October 9, 2024 05:32

tangjj11 temporarily deployed to WindowsCILock October 9, 2024 05:33 — with GitHub Actions Inactive

tangjj11 temporarily deployed to WindowsCILock October 18, 2024 08:46 — with GitHub Actions Inactive

tangjj11 had a problem deploying to WindowsCILock October 18, 2024 09:12 — with GitHub Actions Failure

tangjj11 force-pushed the simd branch from d6a0940 to b10a4b8 Compare October 18, 2024 12:24

tangjj11 temporarily deployed to WindowsCILock October 18, 2024 12:24 — with GitHub Actions Inactive

tangjj11 had a problem deploying to WindowsCILock October 18, 2024 12:53 — with GitHub Actions Failure

tangjj11 force-pushed the simd branch from b10a4b8 to 14d7d62 Compare October 19, 2024 07:10

tangjj11 temporarily deployed to WindowsCILock October 19, 2024 07:10 — with GitHub Actions Inactive

tangjj11 had a problem deploying to WindowsCILock October 19, 2024 07:34 — with GitHub Actions Error

tangjj11 added 3 commits October 19, 2024 15:45

[SYCL][COMPAT] Add vectorized_ternary and vectorized_with_pred.

45b4436

Add vectorized_ternary and vectorized_with_pred. Update relu and vectorized_binary. Signed-off-by: Tang, Jiajun [email protected]

Fix comment.

827e50b

fix comment.

829c529

tangjj11 force-pushed the simd branch from 14d7d62 to 927024b Compare October 19, 2024 07:49

tangjj11 temporarily deployed to WindowsCILock October 19, 2024 07:49 — with GitHub Actions Inactive

tangjj11 had a problem deploying to WindowsCILock October 19, 2024 08:13 — with GitHub Actions Failure

tangjj11 force-pushed the simd branch from 927024b to bedaf66 Compare October 19, 2024 08:59

tangjj11 temporarily deployed to WindowsCILock October 19, 2024 08:59 — with GitHub Actions Inactive

tangjj11 had a problem deploying to WindowsCILock October 19, 2024 09:23 — with GitHub Actions Failure

Fix comment.

d43849f

tangjj11 force-pushed the simd branch from bedaf66 to d43849f Compare October 20, 2024 03:46

tangjj11 temporarily deployed to WindowsCILock October 20, 2024 03:46 — with GitHub Actions Inactive

tangjj11 temporarily deployed to WindowsCILock October 20, 2024 04:11 — with GitHub Actions Inactive

joeatodd requested review from Alcpz and joeatodd October 23, 2024 08:23

joeatodd approved these changes Oct 23, 2024

View reviewed changes

Alcpz approved these changes Oct 23, 2024

View reviewed changes

martygrant merged commit 2c39d67 into intel:sycl Oct 23, 2024
13 checks passed

tangjj11 deleted the simd branch October 23, 2024 13:01

This was referenced Oct 25, 2024

[SYCLomatic] Support migration of 3 runtime Surface APIs. oneapi-src/SYCLomatic#2414

Merged

[SYCLomatic] Support migration of 36 SIMD math APIs. oneapi-src/SYCLomatic#2193

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][COMPAT] Add vectorized_ternary and vectorized_with_pred. #15550

[SYCL][COMPAT] Add vectorized_ternary and vectorized_with_pred. #15550

tangjj11 commented Sep 30, 2024

Uh oh!

Alcpz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joeatodd left a comment

Uh oh!

Alcpz commented Oct 23, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[SYCL][COMPAT] Add vectorized_ternary and vectorized_with_pred. #15550

[SYCL][COMPAT] Add vectorized_ternary and vectorized_with_pred. #15550

Conversation

tangjj11 commented Sep 30, 2024

Uh oh!

Alcpz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joeatodd left a comment

Choose a reason for hiding this comment

Uh oh!

Alcpz commented Oct 23, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants